Thanks @Azeirah !

I took the time to try the package out, and I have some feedback, in case you're interested. @kentonv is the one who actually merges these pull requests onto the website; I don't know if they're showstoppers for him or not.

So I'll file a few bugs against the original app, and provide links here. I'm grateful that you're uploading this, and I look forward to other Sandstorm users using this app!

OK I think the only issues I could come up with were:

• (sandstorm package): Use more informative action title Azeirah/brainstorm#11
• (sandstorm package): Synchronize URL to Sandstorm address bar Azeirah/brainstorm#12

Thanks again to you for choosing to share the package more widely! I hope it's OK for me to provide a quick review like this and file issues; these comments are distributed in the hope that they will be useful.

Also, it'd be lovely if you could distribute the sandstorm-files.list and sandstorm-pkgdef.capnp as part of the brainstorm repo. That way, if someone else wants to modify these for their own use, or submit pull requests against them, it would be possible.

Assigning this to @kentonv for merging into the app list.

UPDATE: I can't do that because I don't have the power to assign on this repo! Never mind.

Thanks for opening the issues @paulproteus. Where can I find this sandstorm-files.list file? It's not in my local brainstorm directory.

It depends how you did the packaging. Are you using vagrant-spk per https://docs.sandstorm.io/en/latest/vagrant-spk/packaging-tutorial/ , or the raw spk tool per https://docs.sandstorm.io/en/latest/developing/raw-packaging-guide/ ? vagrant-spk is new since ~March, so probably you used the raw tooling, now that I think about it.

Actually either way I think it should be in the same directory as sandstorm-pkgdef.capnp. If you can't find it there, then hmm, you might have lost it; it's not a huge deal.

@paulproteus I was using meteor-spk. At no point was that file generated, I ran sudo meteor-spk pack.

Ah hah, right, I forgot about meteor-spk!

Probably should document on the repo somewhere that it's built with meteor-spk then.

Neither of these are data-loss bugs, and neither of them are usability show-stoppers, IMHO.

@kentonv my vote is to merge this pull request and let any further changes come in as follow-up pull requests.

Hey @Azeirah, I see you updated brainstorm.spk to fix one of Asheesh's concerns. Thanks! Note that in the future, when you upload new versions, it will be very important that you put the new version at a new URL while keeping the old version available at the original URL, because Sandstorm checks the package against a hash before installing and will reject the package if its hash does not match. You'll need to send a pull request here to update the app list to the new version.

Thanks!